Skip to content

Exclude appveyor config#1287

Merged
brettcannon merged 4 commits intomicrosoft:masterfrom
brettcannon:exclude-appveyor-config
Apr 5, 2018
Merged

Exclude appveyor config#1287
brettcannon merged 4 commits intomicrosoft:masterfrom
brettcannon:exclude-appveyor-config

Conversation

@brettcannon
Copy link
Copy Markdown
Member

@brettcannon brettcannon commented Apr 3, 2018

Fixes #1236

This pull request:

  • Has a title summarizes what is changing
  • Includes a news entry file (remember to thank yourself!)
  • Has unit tests & code coverage is not adversely affected (within reason)
  • Works on all actively maintained versions of Python (e.g. Python 2.7 & the latest Python 3 release)
  • Works on Windows 10, macOS, and Linux (e.g. considered file system case-sensitivity)

@brettcannon brettcannon requested a review from DonJayamanne April 3, 2018 19:59
DonJayamanne
DonJayamanne reviewed Apr 4, 2018
View reviewed changes
Copy link
Copy Markdown

@DonJayamanne DonJayamanne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for sorting this, will review

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 5, 2018

Codecov Report

Merging #1287 into master will decrease coverage by 0.45%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1287      +/-   ##
==========================================
- Coverage   71.06%   70.61%   -0.46%     
==========================================
  Files         269      266       -3     
  Lines       12383    12284      -99     
  Branches     2190     2147      -43     
==========================================
- Hits         8800     8674     -126     
- Misses       3450     3487      +37     
+ Partials      133      123      -10
Impacted Files Coverage Δ
src/client/common/configuration/service.ts 69.23% <0%> (-24.89%) ⬇️
src/client/debugger/mainV2.ts 56.3% <0%> (-19.73%) ⬇️
.../client/debugger/DebugClients/RemoteDebugClient.ts 17.64% <0%> (-17.36%) ⬇️
...client/debugger/DebugServers/LocalDebugServerV2.ts 60.86% <0%> (-13.05%) ⬇️
src/client/debugger/DebugClients/DebugFactory.ts 72.72% <0%> (-9.1%) ⬇️
...rc/client/debugger/DebugServers/BaseDebugServer.ts 66.66% <0%> (-6.67%) ⬇️
src/client/activation/analysis.ts 12.05% <0%> (-4.11%) ⬇️
src/client/common/net/socket/socketServer.ts 84.61% <0%> (-2.57%) ⬇️
src/client/debugger/PythonProcess.ts 48.75% <0%> (-2.5%) ⬇️
...c/client/debugger/DebugClients/LocalDebugClient.ts 51.96% <0%> (-2%) ⬇️
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d213a79...aeab69a. Read the comment docs.

@brettcannon brettcannon merged commit 72ef2ab into microsoft:master Apr 5, 2018
@brettcannon brettcannon deleted the exclude-appveyor-config branch April 5, 2018 19:35
@brettcannon
Copy link
Copy Markdown
Member Author

brettcannon commented Apr 5, 2018

Thanks for the review!

@lock lock Bot locked as resolved and limited conversation to collaborators Jul 31, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@DonJayamanne DonJayamanne DonJayamanne left review comments

+1 more reviewer

@MikhailArkhipov MikhailArkhipov MikhailArkhipov approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Remove AppVeyor file from extension build output

3 participants

@brettcannon @DonJayamanne @MikhailArkhipov